Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poi_access_points added for instance #3982

Merged
merged 3 commits into from
Apr 24, 2023
Merged

poi_access_points added for instance #3982

merged 3 commits into from
Apr 24, 2023

Conversation

azime
Copy link
Contributor

@azime azime commented Apr 20, 2023

No description provided.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

woshilapin
woshilapin approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do something on navitia-configurator for this new parameter?

Also, Sonar is complaining about coverage. I'm not sure if that's possible to improve it for such a PR, I guess you know better than me.

@xlqian
Copy link
Member

xlqian commented Apr 21, 2023 •
edited
Loading

@woshilapin Indeed, we need to add that parameter in navitia-configurator to expose it, but nothing will be broken. in terms of sonar, by and large, codes in tyr are covered poorly... we do test the migration (both upgrade and downgrade), but the HTTP API is barely tested...

@azime azime merged commit 4e14ff6 into dev Apr 24, 2023
@azime azime deleted the poi_access_points_for_instance branch April 24, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@xlqian xlqian xlqian approved these changes

@pbench pbench pbench approved these changes

@kadhikari kadhikari Awaiting requested review from kadhikari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azime @xlqian @woshilapin @pbench