Navitia-Geovelo mapping update #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wassimbenaissa
changed the title
kadhikari
approved these changes
May 3, 2023
stifoon
reviewed
May 3, 2023
| @@ -188,11 +188,11 @@ def _call_geovelo(self, url, method=requests.post, data=None): | |||
| @staticmethod | |||
| def get_geovelo_tag(geovelo_response): | |||
| if geovelo_response['title'] == 'RECOMMENDED': | |||
| return 'rapid' | |||
| return 'balanced' | |||
| elif geovelo_response['title'] == 'FASTER': | |||
There was a problem hiding this comment.
I would have mapped "rapid" with this one : rapid is a well-known tag in Navitia, not shorter ;)
There was a problem hiding this comment.
Yep you'r right, but our front team use the "shortest" tag to highlight the "itinéraire rapide"
stifoon
reviewed
May 3, 2023
| elif geovelo_response['title'] == 'FASTER': | ||
| return 'shortest' | ||
| elif geovelo_response['title'] == 'SAFER': | ||
| return 'balanced' | ||
| return 'comfort' | ||
| elif geovelo_response['title'] == 'BIS': | ||
| return 'comfort' |
There was a problem hiding this comment.
so there could be 2 comfort solutions ?
stifoon
approved these changes
May 4, 2023
pbench
approved these changes
May 10, 2023
azime
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following several customer feedback, I have adjusted the Navitia geolveo alternatives mapping.