[Kraken]: Journey status is NO_SERVICE if stop used is deleted by disruption #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uption * Some small refactors to share code in kraken * Update doc (also in navitia-proto) * Adjust bypass_disruption link creation * Tests (ability to send both chaos and kirin disruptions) JIRA: https://navitia.atlassian.net/browse/NAV-1987 + https://navitia.atlassian.net/browse/NAV-1990
pbench
approved these changes
May 5, 2023
If status is already NO_SERVICE from pt_not_served_in_rt, it's useless to also iterate over disruptions.
|
Kudos, SonarCloud Quality Gate passed! |
kadhikari
changed the title
pbougue
pushed a commit
that referenced
this pull request
Aug 7, 2023
Sometimes none is available because the whole VJ is removed. So getting the freshest returns a VJ unusable in RT. Fixes almost "invisible" bug in #3995: case of a trip being canceled by a disruption without NO_SERVICE effect (see fixed test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bypass_disruptionlink creationJIRA: https://navitia.atlassian.net/browse/NAV-1987 + https://navitia.atlassian.net/browse/NAV-1990