[Jormungandr] [Ridesharing]: Add two params while calling OuestGo #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbougue
reviewed
May 5, 2023
There was a problem hiding this comment.
It's not clearly specified anywhere that OuestGo garanties that pickup=from and dropoff=to.
Same goes for the TZ of mindate and maxdate.
If @wassimbenaissa (or @stifoon) is OK with those, code looks OK to me (just comments/naming).
| @@ -62,6 +62,8 @@ | |||
| WEEK_DAYS_MAPPING = ("monday", "tuesday", "wednesday", "thursday", "friday", "saturday", "sunday") | |||
| COVERAGE_ANY_BETA = "any-beta" | |||
| BEST_BOARDING_POSITION_KEY = "{}-{}" | |||
| ONE_DAY = 86400 | |||
There was a problem hiding this comment.
More pythonic: You can probably use datetime.timedelta(days=1).total_seconds() instead of 86400.
source/jormungandr/jormungandr/scenarios/ridesharing/ouestgo.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/scenarios/ridesharing/ouestgo.py
Outdated
Show resolved
Hide resolved
pbougue
reviewed
May 5, 2023
wassimbenaissa
approved these changes
May 5, 2023
added 2 commits
May 5, 2023 16:35
|
Kudos, SonarCloud Quality Gate passed! |
pbougue
approved these changes
May 5, 2023
kadhikari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two more parameters added while calling OuestGo
Departure origin and pickup point is the same.
Drop off and arrival point is the same.
For more details: https://navitia.atlassian.net/browse/NAV-2006