Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/prepare navitia-pre-commit as it is to be privatized #4007

Merged
merged 3 commits into from
May 22, 2023
Merged

Fix/prepare navitia-pre-commit as it is to be privatized #4007

merged 3 commits into from
May 22, 2023

Conversation

pbougue
Copy link
Contributor

@pbougue pbougue commented May 17, 2023 •
edited
Loading

Prepare for more private deps

@pbougue pbougue force-pushed the fix_private_pre-commit branch 6 times, most recently from 860ecde to f537137 Compare May 17, 2023 10:44
@woshilapin
Copy link
Contributor

github.com/hove-io/navitia-pre-commit has been reopened 🤷

@pbougue pbougue force-pushed the fix_private_pre-commit branch 4 times, most recently from 5fed1ac to 189f89d Compare May 17, 2023 13:53
Pierre-Etienne Bougue added 3 commits May 17, 2023 16:43
Fix pre-commit after repo as been privatized
b8f5649 
Only "issue" is that local update of navitia-pre-commit requires a
`pre-commit run` or a `pre-commit autoupdate`.
Remove sed for ssh replacement
3d542c9 
Now that a cleaner solution is available
Remove unused codecov conf
7a53170
@pbougue pbougue force-pushed the fix_private_pre-commit branch from 189f89d to 7a53170 Compare May 17, 2023 15:27
@pbougue pbougue changed the title Attempt to fix pre-commit after repo as been privatized Attempt to fix pre-commit after repo has been privatized May 17, 2023
@pbougue pbougue changed the title Attempt to fix pre-commit after repo has been privatized Attempt to fix navitia-pre-commit as it is to be privatized May 17, 2023
@pbougue pbougue changed the title Attempt to fix navitia-pre-commit as it is to be privatized Fix/prepare navitia-pre-commit as it is to be privatized May 17, 2023
@pbougue pbougue marked this pull request as ready for review May 17, 2023 16:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pbougue pbougue merged commit 0969ae1 into dev May 22, 2023
@pbougue pbougue deleted the fix_private_pre-commit branch May 22, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@azime azime azime approved these changes

@xlqian xlqian xlqian approved these changes

@pascal-vs pascal-vs pascal-vs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbougue @woshilapin @azime @xlqian @pascal-vs