[Jormungandr] Fix transfer path when no access points is reachable #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbench
approved these changes
Jul 27, 2023
xlqian
force-pushed
the
fix_transfer_path_when_no_access_points_is_reachable
branch
from
1942579 to
0b11e4e
Compare
woshilapin
reviewed
Jul 27, 2023
| @@ -282,11 +282,17 @@ def _do_access_point_transfer(self, section, prev_section_mode, next_section_mod | |||
| origins, | |||
| destinations, | |||
| FallbackModes.walking.name, | |||
| section.duration * 2, | |||
| section.duration * 3, | |||
There was a problem hiding this comment.
This seems pretty random for a change. Can you explain a bit why we do this change?
There was a problem hiding this comment.
yes, it's an empirical value.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.