[jormungandr] Olympic site params manager #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbench
reviewed
Aug 25, 2023
pbench
reviewed
Aug 25, 2023
| attractivity_virtual_fallback = attractivities_virtual_fallbacks.get("arrival", {}).get(extremity.uri) | ||
| else: | ||
| attractivity_virtual_fallback = attractivities_virtual_fallbacks.get("departure", {}).get(extremity.uri) | ||
| virtual_fallback = attractivity_virtual_fallback.virtual_duration or 0 |
There was a problem hiding this comment.
does this crash when attractivity_virtual_fallback is None because extremity.uri was not found in attractivities_virtual_fallbacks ?
pbench
approved these changes
Aug 25, 2023
azime
force-pushed
the
olympic_site_params_manager
branch
from
1c1a779 to
28f0b67
Compare
woshilapin
force-pushed
the
olympic_site_params_manager
branch
from
28f0b67 to
17775ea
Compare
xlqian
reviewed
Sep 6, 2023
azime
force-pushed
the
olympic_site_params_manager
branch
from
17775ea to
ee7ead4
Compare
xlqian
approved these changes
Sep 6, 2023
azime
force-pushed
the
olympic_site_params_manager
branch
from
ee7ead4 to
155d232
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kadhikari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: NAV-2221
Config example:
