Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jormungandr] delete origin destination allowed ids management #4109

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

kadhikari
Copy link
Contributor

@woshilapin woshilapin removed their request for review September 20, 2023 12:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.
Although I'm not a fan of letting unused code additional_parameters (as discussed indeed, it would be done in multiple deployments to remove it, as the db must be unused before the column is removed).

@pbougue pbougue merged commit 294b8ab into dev Oct 10, 2023
@pbougue pbougue deleted the delete_manage_od_allowed_ids branch October 10, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants