Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jormungandr] Add log in transient socket exception #4115

Merged
merged 4 commits into from
Sep 28, 2023
Merged

[jormungandr] Add log in transient socket exception #4115

merged 4 commits into from
Sep 28, 2023

Conversation

kadhikari
Copy link
Contributor

  • Some key words added in log.
  • Will help to find exception logs on sockets.
  • As discussed with @pbougue and @xlqian it is quite risky to modify the function used every where in jormungandr to call kraken.

@kadhikari kadhikari requested review from pbench and xlqian September 27, 2023 13:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@azime azime merged commit 5edac70 into dev Sep 28, 2023
@azime azime deleted the add_log_in_transient_socket_class branch September 28, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azime azime azime approved these changes

@pbougue pbougue pbougue approved these changes

@pbench pbench Awaiting requested review from pbench

@xlqian xlqian Awaiting requested review from xlqian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kadhikari @azime @xlqian @pbougue @pbench