[Jormungandr]: Config added, init_kraken_instances #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbougue
reviewed
Oct 2, 2023
xlqian
approved these changes
Oct 2, 2023
|
Kudos, SonarCloud Quality Gate passed! |
kadhikari
approved these changes
Oct 4, 2023
pbench
reviewed
Oct 4, 2023
| @@ -155,7 +155,8 @@ def initialization(self): | |||
|
|
|||
| # we fetch the krakens metadata first | |||
| # not on the ping thread to always have the data available (for the tests for example) | |||
| self.init_kraken_instances() | |||
| if app.config.get('INIT_KRAKEN_INSTANCES', False): | |||
There was a problem hiding this comment.
you want to make the init when the parameter is false ?
Suggested change
| if app.config.get('INIT_KRAKEN_INSTANCES', False): | |
| if app.config.get('INIT_KRAKEN_INSTANCES', True): |
There was a problem hiding this comment.
False here is the default value of the .get() 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: NAV-2351