New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jormungandr] attractivities: parse the new file format #4132

Merged

azime merged 3 commits into dev from attractivity_jo

Oct 13, 2023

Contributor

azime commented Oct 11, 2023 •

edited by jira bot

Loading


          parse the new file format

b3054d2

azime requested review from woshilapin, kadhikari, xlqian and pbench

October 11, 2023 09:49


          tests

321980c

pbench approved these changes

View reviewed changes

xlqian reviewed

View reviewed changes

source/jormungandr/jormungandr/olympic_site_params_manager.py Outdated

-                          logger.warning(
-                              "Reading stop points attractivities, file: %s does not exist", olympic_site_params_file
-                          )
+                          logger.debug("Reading stop points attractivities, path does not found")

Member

xlqian Oct 13, 2023

Suggested change

      
                        logger.debug("Reading stop points attractivities, path does not found")
          
                        logger.debug("Reading stop points attractivities, path is empty")

Contributor Author

azime Oct 13, 2023

Done

source/jormungandr/jormungandr/olympic_site_params_manager.py Outdated Show resolved Hide resolved

Member

xlqian commented Oct 13, 2023

what about max_walking_duration_to_pt? shouldn't it be taken into account as well?

xlqian approved these changes

View reviewed changes


          corrections

c98eece

sonarqubecloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

86.7% Coverage
0.0% Duplication

azime merged commit 2b8ab78 into dev

azime deleted the attractivity_jo branch

October 13, 2023 11:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet