Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Cache coords object instead of type_pb2.GeographicalCoord() #4134

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fix: Cache coords object instead of type_pb2.GeographicalCoord() #4134

merged 2 commits into from
Oct 13, 2023

Conversation

kadhikari
Copy link
Contributor

@kadhikari kadhikari commented Oct 12, 2023 •
edited
Loading

Coordinate object of type type_pb2.GeographicalCoord() cannot be cached.
This object should be transformed to jormun object utils.Coords(lat, lon)

Error introduced in #4119

Ticket: https://navitia.atlassian.net/browse/NAV-2397

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kadhikari kadhikari merged commit 6a77f44 into dev Oct 13, 2023
@kadhikari kadhikari deleted the fix_cache_pb_coord branch October 13, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@azime azime azime approved these changes

@xlqian xlqian xlqian approved these changes

@pbench pbench Awaiting requested review from pbench

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadhikari @woshilapin @azime @xlqian