New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refacto filter olympics journeys keep olympics journeys #4139

Merged

azime merged 3 commits into dev from refacto_filter_olympics_journeys_keep_olympics_journeys

Oct 18, 2023

Contributor

azime commented Oct 16, 2023 •

edited by jira bot

Loading

azime added 2 commits

October 16, 2023 17:12


          refactoring

1e62898


          Fix scenario name

816c6d0

azime requested review from woshilapin, kadhikari, xlqian and pbench

October 16, 2023 15:27

xlqian reviewed

View reviewed changes

source/jormungandr/jormungandr/olympic_site_params_manager.py Outdated

Comment on lines 165 to 167

+                      if api_request.get("_keep_olympics_journeys") is None and any(
+                          [olympic_site_params.get("departure_scenario"), olympic_site_params.get("arrival_scenario")]
+                      ):

Member

xlqian Oct 17, 2023

i'm not very sure, but isn't olympic_site_params supposed to be None, if neither from nor to is olympics site?

Suggested change

      
                    if api_request.get("_keep_olympics_journeys") is None and any(
          
                        [olympic_site_params.get("departure_scenario"), olympic_site_params.get("arrival_scenario")]
          
                    ):
          
                    if api_request.get("_keep_olympics_journeys") is None and olympic_site_params:

Contributor Author

azime Oct 17, 2023

👍 Done


          refacto

99b5a36

sonarqubecloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

94.1% Coverage
0.0% Duplication

woshilapin approved these changes

View reviewed changes

xlqian approved these changes

View reviewed changes

azime merged commit 4aebd1b into dev

azime deleted the refacto_filter_olympics_journeys_keep_olympics_journeys branch

October 18, 2023 08:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet