Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden add_poi_shape #4142

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Hidden add_poi_shape #4142

merged 4 commits into from
Oct 20, 2023

Conversation

azime
Copy link
Contributor

@azime azime commented Oct 18, 2023

Jira: NAV-2256

image

@azime azime changed the title Hidden add poi shape Hidden add_poi_shape Oct 18, 2023
@azime azime requested review from kadhikari, xlqian and pbench October 18, 2023 15:01
@@ -92,7 +92,7 @@ def geo_status(self, instance):
return status

@get_serializer(serpy=api.PlacesSerializer)
def get_by_uri(self, uri, request_id, instances=None, current_datetime=None):
def get_by_uri(self, uri, request_id, instances=None, current_datetime=None, _add_poi_shape=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand, we don't use the parameter _add_poi_shape in kraken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@azime azime merged commit ee15d32 into dev Oct 20, 2023
@azime azime deleted the hidden_add_poi_shape branch October 20, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants