New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depth=2 for access_points objects #4172

Merged

azime merged 1 commit into dev from access_points_depth_2

Jan 29, 2024

Contributor

azime commented Nov 22, 2023 •

edited

Loading

Some benches :

API	Before correction (time ms)	After correction (time ms)	query
stop_points	147.80	153.05	/stop_points?depth=2&count=500&
places_nearby	201.89	254.66	stop_areas/stop_area:IDFM:474151/places_nearby?type[]=stop_point&depth=2&distance=1936&count=500&
terminus_schedules	209.20	239.12	/stop_areas/stop_area:IDFM:73626/terminus_schedules?depth=2&forbidden_uris[]=physical_mode:Bus&forbidden_uris[]=physical_mode:Car&forbidden_uris[]=physical_mode:Bike&count=20&
stop_schedules	206.57	237.03	stop_areas/stop_area:IDFM:73626/stop_schedules?depth={depth}&forbidden_uris[]=physical_mode:Bus&forbidden_uris[]=physical_mode:Car&forbidden_uris[]=physical_mode:Bike&count=20&
journeys	466.75	178.06	/journeys?from=stop_area:IDFM:474151&to=stop_area:IDFM:71161&allowed_id[]=network:IDFM:741&_override_scenario=distributed&

Only places_nearby API with depth = 2, 3:

depth = 2 : 254.66ms (access_points in response)
depth = 3 : 525.89ms ( In prod)


          depth=2 for access_points objects

dfe03fb

Contributor

wassimbenaissa commented Nov 22, 2023

<3

sonarqubecloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

azime added do_not_merge ok_to review labels

azime requested review from kadhikari, xlqian, wassimbenaissa, pbench and SGrenet

November 22, 2023 16:31

pbench approved these changes

View reviewed changes

xlqian approved these changes

View reviewed changes

azime removed do_not_merge ok_to review labels

azime merged commit 6dd63a1 into dev

azime deleted the access_points_depth_2 branch

January 29, 2024 11:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xlqian xlqian approved these changes

pbench pbench approved these changes

kadhikari Awaiting requested review from kadhikari

wassimbenaissa Awaiting requested review from wassimbenaissa

SGrenet Awaiting requested review from SGrenet

Labels

None yet