-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tyr Worker] Process poi and push to asgard s3 #4212
Conversation
raise Exception("Asgard Bucket is None") | ||
|
||
bash_command = ( | ||
"env REQUESTS_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even though it's corrected here: https://github.com/hove-io/navitia/pull/4212/files#diff-9677996dffe09856de00ff00f281b66e799a3187047cbb83bf62efe46d434186R30, I still have to put the env var here and I have absolutely no idea why... otherwise the aws sync
wouldn't work...
for i, zone in enumerate(zones): | ||
output_id = "{}_{}_{}".format(poi_id, i, instance_name) | ||
output = {'id': output_id} | ||
output.update(zone) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can have a poi with several zones but all with the same shape ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeahhhhh, I admit that this was not well thought through...
the need is for a given shape, we wish it could be excluded based on a list of modes and a list of ranges of date, so the ideal format in my opinion is
{
"name": "poi:toto",
"shape": "POLYGON ((...))",
"excluded_on": [
{
"modes": [
"walking",
"bike"
],
"periods": [
{
"from": "20240708",
"to": "20240709"
},
{
"from": "202407010",
"to": "20240711"
}
]
},
{
"modes": [
"car"
],
"periods": [
{
"from": "202407010",
"to": "202407011"
}
]
}
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok ! you have the same shape but for different modes, or different activation periods, did I get it right ?
|
No description provided.