Adding cache for transfer_path #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbench
approved these changes
Feb 8, 2024
pbench
approved these changes
Feb 8, 2024
xlqian
reviewed
Feb 9, 2024
| def _get_access_points(self, stop_point_uri, access_point_filter=lambda x: x): | ||
| sub_request_id = "{}_transfer_start_{}".format(self._request_id, stop_point_uri) | ||
| stop_points = self._instance.georef.get_stop_points_from_uri(stop_point_uri, sub_request_id, depth=2) | ||
| def _get_access_points(self, pt_object, access_point_filter=lambda x: x): |
There was a problem hiding this comment.
there should be a more proper way to do it, you can create an abstract function in PtPlanner that returns access points, and the implementation should be "hidden" in the concrete class base on the type of PtPlanner,
|
|
||
| def _do_access_point_transfer(self, section, prev_section_mode, next_section_mode): | ||
| access_points = self.get_underlying_access_points(section, prev_section_mode, next_section_mode) | ||
| return ( |
There was a problem hiding this comment.
We just need to be cautious/aware of the huge amount of string that could be generated by this thus impacting the performance cache/redis, (it's not particularly worrying since Asgard has been doing so...) On top of that, serialize/deserialize could be time-consuming as well
xlqian
approved these changes
Feb 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: NAV-2719