Show natural opg journeys #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlqian
approved these changes
Feb 16, 2024
| @@ -56,6 +56,10 @@ def __repr__(self): | |||
| return "{}-{}-{}".format(self.instance_name, self.s3_object.key, self.s3_object.e_tag) | |||
|
|
|||
|
|
|||
| def has_applicable_scenario(api_request): | |||
| return True if api_request.get("olympic_site_params") else False | |||
There was a problem hiding this comment.
Suggested change
| return True if api_request.get("olympic_site_params") else False | |
| return bool(api_request.get("olympic_site_params")) |
Comment on lines
111
to
115
| return ( | ||
| query_show_natural_opg_journeys | ||
| if query_show_natural_opg_journeys is not None | ||
| else conf_additional_parameters.get("show_natural_opg_journeys", False) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| return ( | |
| query_show_natural_opg_journeys | |
| if query_show_natural_opg_journeys is not None | |
| else conf_additional_parameters.get("show_natural_opg_journeys", False) | |
| ) | |
| return query_show_natural_opg_journeys or conf_additional_parameters.get("show_natural_opg_journeys", False) |
pbench
approved these changes
Feb 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira:
NAV-2761
NAV-2762
NAV-2763