Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix excluded_zones generator #4223

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Fix excluded_zones generator #4223

merged 3 commits into from
Feb 22, 2024

Conversation

azime
Copy link
Contributor

@azime azime commented Feb 22, 2024 •
edited by jira bot
Loading

Jira: NAV-2787

@azime azime requested review from kadhikari and xlqian February 22, 2024 10:02
adrien3d
adrien3d approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@adrien3d adrien3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.9% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@azime azime merged commit d5cce15 into dev Feb 22, 2024
8 of 9 checks passed
@azime azime deleted the fix_excluded_zones_files branch February 22, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien3d adrien3d adrien3d approved these changes

@kadhikari kadhikari kadhikari approved these changes

@xlqian xlqian Awaiting requested review from xlqian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azime @adrien3d @kadhikari