[Distributed Excluded Zone] Handle when depart is in an excluded zone #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadhikari
reviewed
Mar 5, 2024
| @classmethod | ||
| @cache.memoize(app.config[str('CACHE_CONFIGURATION')].get(str('ASGARD_S3_DATA_TIMEOUT'), 1 * 60)) | ||
| def is_excluded(cls, obj, mode, timestamp): | ||
| print(mode) |
azime
reviewed
Mar 5, 2024
| @classmethod | ||
| @cache.memoize(app.config[str('CACHE_CONFIGURATION')].get(str('ASGARD_S3_DATA_TIMEOUT'), 1 * 60)) | ||
| def is_excluded(cls, obj, mode, timestamp): | ||
| print(mode) |
There was a problem hiding this comment.
Suggested change
| print(mode) | |
| print(mode) |
to remove
|
|
||
| from jormungandr import app, memory_cache, cache | ||
| from jormungandr.resource_s3_object import ResourceS3Object | ||
|
|
||
|
|
||
| class ExcludedZonesManager: | ||
| excluded_shapes = dict() # type: Dict[str, shapely.geometry] | ||
|
|
||
| @staticmethod | ||
| @cache.memoize(app.config[str('CACHE_CONFIGURATION')].get(str('ASGARD_S3_DATA_TIMEOUT'), 24 * 60)) | ||
| def get_object(resource_s3_object): |
There was a problem hiding this comment.
can you add instance_publication_date
There was a problem hiding this comment.
for excluded_zones, they have nothing to do with the data of instance, it does not make sense to relate excluded_zones to instance_publication_date
| ) | ||
| cls.excluded_shapes = [shapely.wkt.loads(zone.get('shape', '')) for zone in excluded_zones] |
xlqian
commented
Mar 5, 2024
azime
approved these changes
Mar 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://navitia.atlassian.net/browse/NAV-2802