Add tags in stats #4232
Merged
Add tags in stats #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbench
approved these changes
Mar 6, 2024
| stat_tag = MAP_JOURNEY_TAG.get(tag, stat_pb2.JOURNEY_TAG_UNKNOWN) | ||
| if stat_tag == stat_pb2.JOURNEY_TAG_UNKNOWN: | ||
| logging.getLogger(__name__).warning("Stat tag not found for {} navitia tag.".format(tag)) | ||
| result.add(stat_tag) |
There was a problem hiding this comment.
I am not sure it is worthwhile to add the tag JOURNEY_TAG_UNKNOWN to the stats proto message 🤷
There was a problem hiding this comment.
I think instead of empty value, better to use this one.
We better not communicate this information to any client and use only for internal analysis.
kadhikari
approved these changes
Mar 7, 2024
| stat_tag = MAP_JOURNEY_TAG.get(tag, stat_pb2.JOURNEY_TAG_UNKNOWN) | ||
| if stat_tag == stat_pb2.JOURNEY_TAG_UNKNOWN: | ||
| logging.getLogger(__name__).warning("Stat tag not found for {} navitia tag.".format(tag)) | ||
| result.add(stat_tag) |
There was a problem hiding this comment.
I think instead of empty value, better to use this one.
We better not communicate this information to any client and use only for internal analysis.
xlqian
approved these changes
Mar 7, 2024
|
adrien3d
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: NAV-2814