Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teminus/stop schedule: add headsign/trip_short_name on display_informations #4312

Merged
merged 10 commits into from
Oct 18, 2024

Conversation

datanel
Copy link
Member

@datanel datanel commented Oct 10, 2024

@datanel datanel requested review from a team, zuniverse, adrien3d, assiadialeb, kadhikari, xlqian and azime and removed request for a team, zuniverse, adrien3d and assiadialeb October 10, 2024 12:47
@datanel datanel force-pushed the headsign/terminus_schedule branch from 68cef9d to e1f933f Compare October 10, 2024 13:00
@datanel datanel force-pushed the headsign/terminus_schedule branch from 856d99a to 4861f1e Compare October 16, 2024 13:42
@datanel
Copy link
Member Author

datanel commented Oct 16, 2024

@xlqian changes made

@datanel datanel requested a review from xlqian October 16, 2024 13:44
@datanel datanel force-pushed the headsign/terminus_schedule branch 2 times, most recently from 32ec581 to db78897 Compare October 17, 2024 09:31
@@ -114,6 +114,8 @@ jobs:
build:
runs-on: [self-hosted, corefront, sandbox]
needs: [credentials, checks, precommit]
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true # see https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@datanel datanel force-pushed the headsign/terminus_schedule branch from db78897 to 7f1b30e Compare October 17, 2024 12:57
@xlqian xlqian force-pushed the headsign/terminus_schedule branch from f43986b to 96ef27b Compare October 18, 2024 10:29
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@xlqian xlqian merged commit 6b42cbe into dev Oct 18, 2024
15 of 16 checks passed
@xlqian xlqian deleted the headsign/terminus_schedule branch October 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants