fix(web): fix lost scrollpos on deep link to timeline asset, scrub stop #16305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the problems in maintaining scroll position (i.e. to a given deep-linked bucket) as the buckets above the current bucket as loaded and change height. The same problem also happened when clicking on the scrub bar on an unloaded part of the timeline (towards the bottom).
The root causes:
id='bucket'
was changed to a bucket class instead, causing_updateLastIntersectedBucketDate
to fail_updateLastIntersectedBucketDate
was not working properly anyways, since on scrub, the scrubbar creates an invisible overlay over the entire#asset-grid
causing getElementAtPoint to fail.Other changes
How Has This Been Tested?