Fix: page_chars attribute does not exist in some formats of PDF #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHuSh
reviewed
Dec 2, 2024
| @@ -956,8 +956,12 @@ def __images__(self, fnm, zoomin=3, page_from=0, | |||
| enumerate(self.pdf.pages[page_from:page_to])] | |||
| self.page_images_x2 = [p.to_image(resolution=72 * zoomin * 2).annotated for i, p in | |||
| enumerate(self.pdf.pages[page_from:page_to])] | |||
| self.page_chars = [[{**c, 'top': c['top'], 'bottom': c['bottom']} for c in page.dedupe_chars().chars if self._has_color(c)] for page in | |||
| self.pdf.pages[page_from:page_to]] | |||
| try: | |||
There was a problem hiding this comment.
I did not get it. Why try is in another try?
There was a problem hiding this comment.
The second try exists to catch and handle exceptions that may occur during parsing of page_chars, so that parsing of the entire PDF does not fail due to parsing problems on individual pages. In the original code, if an exception occurs in page_chars, it is not handled but simply reported as an error and exited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In #3335 someone suggested to upgrade pdfplumber==0.11.1, but that didn't solve it.
It's actually the special formatting in some of the pdfs that triggers the problem.
Type of change