Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storage engine #4341

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Conversation

KennyDizi
Copy link
Contributor

@KennyDizi KennyDizi commented Jan 3, 2025

What problem does this PR solve?

  • Bring STORAGE_IMPL back in rag/svr/cache_file_svr.py
  • Simplify storage connection when working with AWS S3

Type of change

  • Refactoring

@KevinHuSh KevinHuSh added the ci Continue Integration label Jan 3, 2025
@JinHai-CN
Copy link
Contributor

JinHai-CN commented Jan 3, 2025

@KennyDizi Please remove the unused import statement.

rag/utils/s3_conn.py:4:29: F401 [*] `botocore.client.Config` imported but unused
  |
2 | import boto3
3 | from botocore.exceptions import ClientError
4 | from botocore.client import Config
  |                             ^^^^^^ F401
5 | import time
6 | from io import BytesIO
  |
  = help: Remove unused import: `botocore.client.Config`

@KennyDizi
Copy link
Contributor Author

Thanks @JinHai-CN I've adjusted the code accordingly.

@KevinHuSh KevinHuSh merged commit bad764b into infiniflow:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continue Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants