Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify img2text model by tag #5063

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Specify img2text model by tag #5063

merged 2 commits into from
Feb 18, 2025
+38 −15

Conversation

hrchu
Copy link
Contributor

@hrchu hrchu commented Feb 18, 2025 •
edited by KevinHuSh
Loading

What problem does this PR solve?

The current design is not well-suited for multimodal models, as each model can only be configured for a single purpose—either chat or Img2txt. To work around this limitation, we use model aliases such as gpt-4o-mini and gpt-4o-mini-2024-07-18.

To fix this, this PR allows specifying the Img2txt model by tag instead of model_type.

Type of change

  • Refactoring

hrchu added 2 commits February 18, 2025 09:13
@hrchu
Update model config
a0c2768 
Remove alias, as the image2text model can now be selected using tags
@hrchu
Allow selecting image-to-text models by tag
0f35520
@KevinHuSh KevinHuSh added the ci Continue Integration label Feb 18, 2025
@KevinHuSh KevinHuSh merged commit 4694604 into infiniflow:main Feb 18, 2025
3 checks passed
cike8899 added a commit to cike8899/ragflow that referenced this pull request Feb 18, 2025
@cike8899
Feat: Extract the common parts of groupImage2TextOptions and groupOpt…
c5e9115 
…ionsByModelType infiniflow#5063
@cike8899 cike8899 mentioned this pull request Feb 18, 2025
Merged
1 task
KevinHuSh pushed a commit that referenced this pull request Feb 18, 2025
@cike8899
Feat: Extract the common parts of groupImage2TextOptions and groupOpt…
375e727 
…ionsByModelType #5063 (#5074)

### What problem does this PR solve?

Feat: Extract the common parts of groupImage2TextOptions and
groupOptionsByModelType #5063

### Type of change


- [x] New Feature (non-breaking change which adds functionality)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continue Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrchu @KevinHuSh