Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Upload file UI/UX enhancements #5359

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

Omarlsg98
Copy link
Contributor

@Omarlsg98 Omarlsg98 commented Feb 25, 2025

What problem does this PR solve?

Modifies the UX for uploading process on the website.

  • Adds option to parse on creation the files
  • Adds progress bar to display progress of chunk
  • Adds per file feedback on uploading operation

Screenshots:

  • Show files uploading:
    image

  • Errors on specific files
    image

Type of change

  • New Feature (non-breaking change which adds functionality)

@Omarlsg98 Omarlsg98 changed the title Feat: Upload file UI enhancements Feat: Upload file UI/UX enhancements Feb 25, 2025
@KevinHuSh KevinHuSh requested a review from cike8899 February 26, 2025 01:37
@yingfeng yingfeng added the ci Continue Integration label Feb 26, 2025
@cike8899
Copy link
Contributor

Please fix the error in uploading files

image

@Omarlsg98
Copy link
Contributor Author

@cike8899 I'm not able to reproduce your error, can you give me more details on how it occurs?

Also, please notice I changed a couple of lines in the API server to return the successful files. Maybe you need to redeploy the backend with those changes(?)

    err, files = FileService.upload_document(kb, file_objs, current_user.id)
    files = [f[0] for f in files] # remove the blob

    if err:
        return get_json_result(
            data=files, message="\n".join(err), code=settings.RetCode.SERVER_ERROR)
    return get_json_result(data=files)

@cike8899
Copy link
Contributor

image

By default, no document parsing is required after uploading the file.

@Omarlsg98
Copy link
Contributor Author

@cike8899 is there any reason the user would not want to parse the files? As far as i see the documents are useless if they are not parsed

@KevinHuSh
Copy link
Collaborator

Appreciations!

After uploading, people may want to alter the chunk method configuration instead of chunking by default method.
The chunking configurations could be different from file to file.

@Omarlsg98
Copy link
Contributor Author

@KevinHuSh That make sense! Maybe it will be better if the user could choose/override chunking methods directly on the upload file modal. Maybe for a future PR.
@cike8899 I changed parseOnCreation to be false by default for now!

@KevinHuSh KevinHuSh merged commit 11e3f5e into infiniflow:main Mar 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continue Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants