This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Added makefile and made all containers buildable #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am interested in adding support for SOGo and want to gauge how well PRs are received on this project. I have made some very basic build files with the included Makefile that allows all containers in the project to be built. It will also build the all in one container. In the future I would like to see the mono container removed and the separate containers to become the standard since this will allow the application to be scaled. I have also added docker-compose files that make deploying to a docker engine server much easier.
I have also updated the individual service containers so they build, but doubt they are anywhere near workable. The only reason I am opening a PR at this point is the state is better than when I found it (following my do no harm mantra) and I want to know if it is even worth making the contribution. My proposed changes will be rather in depth and take me a decent amount of time / effort.
Let me know if you have any concerns with theses additions. If you are interested I will start working on integrating SOGo into the all in one container, then I will work on getting the multiple container setup working.