Skip to content

Commit 41f7873

Browse files
G-RathSimenB
authored andcommitted
feat: add valid-title to recommended ruleset
BREAKING CHANGE: recommend `valid-title` rule
1 parent 7080952 commit 41f7873

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ installations requiring long-term consistency.
169169
| [valid-describe](docs/rules/valid-describe.md) | Enforce valid `describe()` callback | ![recommended][] | |
170170
| [valid-expect](docs/rules/valid-expect.md) | Enforce valid `expect()` usage | ![recommended][] | |
171171
| [valid-expect-in-promise](docs/rules/valid-expect-in-promise.md) | Enforce having return statement when testing with promises | ![recommended][] | |
172-
| [valid-title](docs/rules/valid-title.md) | Enforce valid titles | | ![fixable][] |
172+
| [valid-title](docs/rules/valid-title.md) | Enforce valid titles | ![recommended][] | ![fixable][] |
173173

174174
<!-- end rules list -->
175175

src/__tests__/__snapshots__/rules.test.ts.snap

+1
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ Object {
8080
"jest/valid-describe": "error",
8181
"jest/valid-expect": "error",
8282
"jest/valid-expect-in-promise": "error",
83+
"jest/valid-title": "error",
8384
},
8485
},
8586
"style": Object {

src/rules/valid-title.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export default createRule<[Options], MessageIds>({
8181
docs: {
8282
category: 'Best Practices',
8383
description: 'Enforce valid titles',
84-
recommended: false,
84+
recommended: 'error',
8585
},
8686
messages: {
8787
titleMustBeString: 'Title must be a string',

0 commit comments

Comments
 (0)