-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve accuracy of resolving jest function calls #1119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d49941
to
bab6833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bit of a crazy man's fevered PR - it took a few tries but I think I've finally nailed down a good api for parsing "jest function calls" completely correctly and that shouldn't need painfully being extended with another layer everytime a new nested method is added in Jest (e.g. like
failing
).This also extends to
expect
, which is now scoped though not fully integrated into the core parser.I'm making this PR just for show-and-tell - I'm going to now cherry-pick the actual final implementation (which is
parseJestFnCall_1
) I went with into a new branch and do a bunch of tidying up.During this I realised that we probably need to do a review of each of our rules to decide how they should behave with imports, at least in terms of fixing because a lot of them are are arguably breaking now as you might not be importing the replacement method.
There's also some interesting thinking to be done on import aliasing, as there could be rules that should support arbitrary names now to allow you to be more specific (e.g. we could consider
describe
vsdescribe as context
different).