Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve accuracy of resolving jest function calls #1119

Closed
wants to merge 27 commits into from

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented May 22, 2022

this is a bit of a crazy man's fevered PR - it took a few tries but I think I've finally nailed down a good api for parsing "jest function calls" completely correctly and that shouldn't need painfully being extended with another layer everytime a new nested method is added in Jest (e.g. like failing).

This also extends to expect, which is now scoped though not fully integrated into the core parser.

I'm making this PR just for show-and-tell - I'm going to now cherry-pick the actual final implementation (which is parseJestFnCall_1) I went with into a new branch and do a bunch of tidying up.

During this I realised that we probably need to do a review of each of our rules to decide how they should behave with imports, at least in terms of fixing because a lot of them are are arguably breaking now as you might not be importing the replacement method.

There's also some interesting thinking to be done on import aliasing, as there could be rules that should support arbitrary names now to allow you to be more specific (e.g. we could consider describe vs describe as context different).

@G-Rath G-Rath deleted the support-resolving-source-method2 branch November 11, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant