Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update package urls for homepage, repository, and bugs #1693

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: update package urls for homepage, repository, and bugs #1693

merged 1 commit into from
Jan 13, 2025

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Jan 13, 2025 •
edited
Loading

Re-PR of #1673, with npx sort-package-json ran.

The repository URL was fixed by simply running npm pkg fix, which is what npm publish does prior to publishing.

The addition of the homepage property allows for the URL to the repo to be correctly displayed when hovered over in VS Code when using a proxy registry like in Azure DevOps:

image

Compared to eslint-plugin-regexp, which does have the homepage set:

image

The bugs property was also added to allow for npm bugs to work.

@G-Rath G-Rath changed the title chore(package): fix repository url; add homepage and bugs urls chore: update package urls for homepage, repository, and bugs Jan 13, 2025
G-Rath
G-Rath approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@G-Rath G-Rath merged commit 9c91509 into jest-community:main Jan 13, 2025
44 checks passed
@Fdawgs Fdawgs deleted the chore/package branch January 13, 2025 19:14
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 28.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

@fackfack616 fackfack616 fackfack616 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fdawgs @G-Rath @fackfack616