Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the rules for linting #2651

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

naman9271
Copy link
Contributor

Fixes #2644

Files Modified :

  • .eslintric.js added the linting rules

changes have been made as you said in this comment

Changes Made

  • I have added a lot of rules in the .eslintric with comments what the rules are for

@naman9271
Copy link
Contributor Author

@saghul please review this

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into our eslint config in the @jitsi/eslint-config package. The only rules I am willing to accept here are ones that improve the status quo. Changing spacing to 2 spaces is only happening over my cold dead body.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@naman9271
Copy link
Contributor Author

@saghul changes made please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Prettier for Code Formatting
3 participants