Add autoscaling agent rest api #130
Conversation
skynet/agent.py
Outdated
|
|
||
| log = get_logger(__name__) | ||
| app = FastAPI() |
There was a problem hiding this comment.
Since we are mounting a new app, I reckon we'd want to contain it in its own file perhaps, rather than together with this agent code?
There was a problem hiding this comment.
They need to communicate with one another (that was initially the reason for the temp file as they were in separate modules). I dropped the temp file as they can share a global. If the autoscaler sets the app's state to drain, that state needs to be reflected in the HAProxy agent response. So the LB can stop sending new connections to this machine. No need to stop accepting connections from Skynet itself as HAProxy will handle it.
There was a problem hiding this comment.
I also addressed the rest of the concerns, please have another look
| except Exception as ex: | ||
| log.warning('TCP exception during haproxy-agent check.', ex) | ||
| finally: | ||
| await writer.drain() |
There was a problem hiding this comment.
If the TCP connection is broken, won't this fail?
| # bound to the REST API server as the latter will inform HAProxy if the system was set to drain mode. | ||
|
|
||
| autoscaler_rest_app = FastAPI() | ||
| TRANSCRIBE_GRACEFUL_SHUTDOWN.set(0) |
There was a problem hiding this comment.
Is it necwesssary to initialize it?
No description provided.