bug fixed: Transition.downToUp have a black background container #1560 #2864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add a parameter
oldPage
on apiGetNavigationExt.to()
,oldPage
is the previous page when you push a new page, if you use a customtransition
, we need to change the old page exit transition, otherwise it will show black container in some cases, it fixes the bug:transition: Transition.downToUp have a black background container #1560
When we use
Get.to(() => NextPage(), transition: Transition.downToUp)
, we should change the previous page's exit transition to SlideTopTransition, now use new api:Get.to(() => NextPage(), transition: Transition.downToUp, oldPage: currentPage)
before:
before.mp4
after:
after.mp4
Every PR must update the corresponding documentation in the
code
, and also the readme in english with the following changes.Pre-launch Checklist
///
).