Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyprland: Make sure image window is moved to correct workspace #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thatDudo
Copy link
Contributor

The image window was always opened in the currently focused workspace instead of the workspace belonging to the terminal window. I wasnt sure implementation wise if the change_workspace should be called in wayland.cpp (like move_window) since it can be kept hidden from it without problems.

Copy link

@jstkdng
Copy link
Owner

jstkdng commented Sep 13, 2024

can you post some pics of the issue before/after?

@thatDudo
Copy link
Contributor Author

thatDudo commented Sep 13, 2024

This primarily happens when I open a music file
Screenshot_2024-09-13_15:09:12 2

and switch the workspace.
Screenshot_2024-09-13_15:14:09 2

when the music file closes, the image preview is readded to the currently focused workspace (triggered through the lf terminal window resize).
Screenshot_2024-09-13_15:14:56 2

@jstkdng
Copy link
Owner

jstkdng commented Sep 17, 2024

workspaces aren't treated the same way in wayland compositors so it should be wm dependent. Does this work if the terminal doesn't have a workspace assigned?

@thatDudo
Copy link
Contributor Author

thatDudo commented Sep 17, 2024

workspaces aren't treated the same way in wayland compositors so it should be wm dependent

Ok, then it is probably good to have the function being called from the hyprland.cpp file.

Does this work if the terminal doesn't have a workspace assigned?

I think every window in hyprland always has a workspace assigned to it. The id should be unique even with things that mess with workspaces like hyprsome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants