Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: julienloizelet/ddev-playwright
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.1
Choose a base ref
...
head repository: julienloizelet/ddev-playwright
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.2
Choose a head ref
  • 8 commits
  • 5 files changed
  • 3 contributors

Commits on Feb 7, 2023

  1. Copy the full SHA
    997b75a View commit details

Commits on Mar 29, 2023

  1. Copy the full SHA
    50b82f6 View commit details

Commits on May 24, 2023

  1. Copy the full SHA
    4189d43 View commit details

Commits on Jun 10, 2023

  1. Minor fixups to docker-compose

    rfay committed Jun 10, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    rfay Randy Fay
    Copy the full SHA
    a9fb4af View commit details

Commits on Jun 12, 2023

  1. Merge pull request #6 from rfay/20230610_minor

    Minor fixups to docker-compose
    julienloizelet authored Jun 12, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    b39d003 View commit details
  2. Verified

    This commit was signed with the committer’s verified signature.
    julienloizelet Julien Loizelet
    Copy the full SHA
    2f1204a View commit details
  3. Verified

    This commit was signed with the committer’s verified signature.
    julienloizelet Julien Loizelet
    Copy the full SHA
    3d46210 View commit details
  4. Verified

    This commit was signed with the committer’s verified signature.
    julienloizelet Julien Loizelet
    Copy the full SHA
    037aef9 View commit details
Showing with 29 additions and 16 deletions.
  1. +15 −8 .github/workflows/tests.yml
  2. +11 −0 CHANGELOG.md
  3. +2 −2 docker-compose.playwright.yaml
  4. +0 −2 tests/test.bats
  5. +1 −4 tests/testdata/yarn/package.json
23 changes: 15 additions & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -3,24 +3,29 @@ on:
pull_request:
push:
branches: [ main ]
paths-ignore:
- '**.md'

schedule:
- cron: '25 08 * * *'

workflow_dispatch:
inputs:
debug_enabled:
description: 'Debug with tmate set "debug_enabled"'
required: false
default: "false"
type: boolean
description: Debug with tmate
default: false

permissions:
contents: write

defaults:
run:
shell: bash

env:
NIGHTLY_DDEV_PR_URL: "https://nightly.link/ddev/ddev/actions/runs/1720215802/ddev-linux-amd64.zip"
# Allow ddev get to use a github token to prevent rate limiting by tests
# Allow ddev get to use a GitHub token to prevent rate limiting by tests
DDEV_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Allow `--HEAD` flag when running tests against HEAD
HOMEBREW_NO_INSTALL_FROM_API: 1
@@ -69,15 +74,14 @@ jobs:
mv ddev /usr/local/bin/ddev && chmod +x /usr/local/bin/ddev
- name: Download docker images
run: |
mkdir junk && pushd junk && ddev config --auto && ddev debug download-images >/dev/null
docker pull memcached:1.6 >/dev/null
run: mkdir junk && pushd junk && ddev config --auto && ddev debug download-images >/dev/null

- name: tmate debugging session
uses: mxschmitt/action-tmate@v3
with:
limit-access-to-actor: true
github-token: ${{ secrets.GITHUB_TOKEN }}
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.debug_enabled == 'true'}}
if: github.event.inputs.debug_enabled == 'true'

- name: tests
run: bats tests
@@ -86,5 +90,8 @@ jobs:
# GitHub from turning off tests after 60 days
- uses: gautamkrishnar/keepalive-workflow@v1
if: matrix.ddev_version == 'stable'
with:
commit_message: "chore(*): Automated commit to keep the repository active"
time_elapsed: 55


11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -12,6 +12,17 @@ The public API for this project is defined by the files `docker-compose.playwrig

------

## [1.0.2](https://github.com/julienloizelet/ddev-playwright/releases/tag/v1.0.2) - 2023-06-12
[_Compare with previous release_](https://github.com/julienloizelet/ddev-playwright/compare/v1.0.1...v1.0.2)

### Fixed

- Fix docker-compose file


---


## [1.0.1](https://github.com/julienloizelet/ddev-playwright/releases/tag/v1.0.1) - 2023-02-07
[_Compare with previous release_](https://github.com/julienloizelet/ddev-playwright/compare/v1.0.0...v1.0.1)

4 changes: 2 additions & 2 deletions docker-compose.playwright.yaml
Original file line number Diff line number Diff line change
@@ -4,9 +4,9 @@
#
# This file comes from https://github.com/julienloizelet/ddev-playwright
#
version: '3.6'
services:
playwright:
# If on arm64 machine, edit to use mcr.microsoft.com/playwright:focal-arm64
image: mcr.microsoft.com/playwright:focal
container_name: ddev-${DDEV_SITENAME}-playwright
hostname: ${DDEV_SITENAME}-playwright
@@ -22,4 +22,4 @@ services:
- ../:/var/www/html:rw
external_links:
- ddev-router:${DDEV_HOSTNAME}
command: tail -F anything
command: tail -f /dev/null
2 changes: 0 additions & 2 deletions tests/test.bats
Original file line number Diff line number Diff line change
@@ -41,7 +41,6 @@ teardown() {

echo "# Yarn install in Playwright container" >&3
ddev exec -s playwright yarn install --cwd ./var/www/html/yarn --force
ddev exec -s playwright yarn global add cross-env
# Work around to be able to delete all files after test (in teardown method)
ddev exec -s playwright chmod -R 777 /var/www/html/yarn

@@ -84,7 +83,6 @@ teardown() {

echo "# Yarn install in Playwright container" >&3
ddev exec -s playwright yarn install --cwd ./var/www/html/yarn --force
ddev exec -s playwright yarn global add cross-env
# Work around to be able to delete all files after test (in teardown method)
ddev exec -s playwright chmod -R 777 /var/www/html/yarn

5 changes: 1 addition & 4 deletions tests/testdata/yarn/package.json
Original file line number Diff line number Diff line change
@@ -5,15 +5,12 @@
},
"dependencies": {
"@jest/test-sequencer": "^26.6.3",
"cross-env": "^7.0.3",
"expect-playwright": "^0.8.0",
"hosted-git-info": "^2.8.9",
"jest": "^26.6.3",
"jest-circus": "^26.6.3",
"jest-environment-node": "^27.2.0",
"jest-playwright-preset": "^1.4.3",
"jest-runner": "^26.6.3",
"playwright-chromium": "^1.27.1",
"ws": "^7.4.6"
"playwright-chromium": "^1.27.1"
}
}