Minor fixups to docker-compose #6
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
commented
Jun 10, 2023
| @@ -22,4 +22,4 @@ services: | |||
| - ../:/var/www/html:rw | |||
| external_links: | |||
| - ddev-router:${DDEV_HOSTNAME} | |||
| command: tail -F anything | |||
| command: tail -f /dev/null | |||
There was a problem hiding this comment.
This seems to be the canonical way of doing this, not sure what "anything" is.
| @@ -4,9 +4,9 @@ | |||
| # | |||
| # This file comes from https://github.com/julienloizelet/ddev-playwright | |||
| # | |||
| version: '3.6' | |||
There was a problem hiding this comment.
The version hasn't been used or required by docker-compose for a couple of years at least.
| services: | ||
| playwright: | ||
| # If on arm64 machine, edit to use mcr.microsoft.com/playwright:focal-arm64 |
There was a problem hiding this comment.
This is super important; I imagine you are on an amd64 machine. Not sure why MS doesn't publish multi-arch images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just a couple of minor fixups I noticed when looking at this with @rkoller.