-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish version for "old stable" #144
Comments
The first proposed solution has been implemented in |
Extended explanation for Proposed solution 2. There is one discrepancy that remain in this solution. While package content may be updated from time to time in the repository on GitHub, this isn't reflected by the package version i.e. To this date, there is no one-stop documentation that explains all possible patterns. So I had to do cross-reference and refine my searching keywords for few times. The following are relevant links.
Based on above references, I would like to extend the proposed solution with additional suffix Justification The extended proposal is actually inspired based on suggested upstream versioning that contain suffix I have avoided to use suffix
So, when using tilda Versioning order In terms of Debian package versioning order, see the following list (from top: lower version).
Also, to see how tilda influence the package version order, modify
GUI vs package version It is important to note that GUI version will always show like X.Y.Z (old stable), while the package version will show like Even the package version may have updated version To illustrate the "old stable" version trend, using dummy versions as example:
This extended proposal will benefit end users who tend to regularly update the software, such that latest version can be checked via package manager i.e. Date format
Verdict Hereby, the fullest package version for "old stable" will be established as P.S.: Added Date format for information. |
Test current version Latest source has been downloaded, compiled and installed via package manager. The following output are showing the fullest package version for "old stable" via dpkg i.e.
Test future version (simulation) When
Then, run
Therefore, test above proves that Following successful results by testing both current and future versions, this issue has been confirmed 'implemented' and shall be closed. |
This is an important issue that aims to resolve the duplicate versions of Customizer in this "old stable" repo and the official fork. The possibility of duplicate versions had gone unnoticed for many months; I finally realized to that possibility when issue #127 was raised earlier.
Justification
This issue would have to be addressed sooner or later, either by interim maintainer (myself) or by future contributors. Since I have realized this already, I decided to take on this issue now. We can't have same versions of similar program that are being maintained separately, which will confuse end users as well.
The proposed solution shall prevent or at least reduce the chances of end users reporting at wrong repo, like issue #120 that was turned out to be so.
Proposed solution 1
Basically, the easiest approach is to revise line 2 in
Makefile
and change text fromecho stable
toecho "old stable"
like this:As a result, the output for command line
customizer --version
as well as Customizer GUI will show i.e.4.1.4 (old stable)
that can be distinguished easily. In contrast, the official fork will continue to useecho stable
that will show i.e.4.1.4 (stable)
. But that is not all.Proposed solution 2
[Secondly], the version shown by the package manager that is based on
debian/changelog
. Ideally, the version specified here should reflect the version similar to what is shown by the ouput of command line and GUI i.e.4.1.4 (old stable)
.I could distinguish version from "old stable" by adding the suffix
-orig
or just the revision number-0
to the version indebian/changelog
to indicate that package is created from the 'original' repo; According to Debian Policy Manual, the absence of revision number i.e.4.1.4
is equivalent to with revision number 0 i.e.4.1.4-0
.As a result, the created Debian package will be named as
customizer_4.1.4-0_all.deb
(Tested working using dummy source package; The suffix-0
is preserved, which I initially thought it would be trimmed by debhelper, since documentation claimed "is equivalent").In contrast, the official fork will continue to generate
customizer_4.1.4_all.deb
. Even better, the official fork should add unique suffix to clearly distinguish itself from the original repo as well as other forks. In other words,customizer_4.1.4-kamilion_all.deb
is better than without the fork owner name (This should be suggested as new issue in the official fork anyway).Proposed solution 3
[Thirdly], the source package (
.zip
,.tar.gz
) is named neither with the word-orig
nor the revision number-0
! Aside from the GitHub code repository page, links to download source packages are found in releases and tags pages. Upon clicking one of these links to respective package, the download dialog will show REPONAME-TAG.tar.gz i.e. "Customizer-4.1.4.tar.gz".Therefore, tags might be better renamed to contain revision number
-0
for "old stable" repo. This shall be applied from patch release 4.1.2, which is the first distinguished release since the official fork has been created. To apply the solutions appropriately, there is a need to:Proposed solutions are effective from 4.1.4 and onwards, while limited for 4.1.2 and 4.1.3.
The text was updated successfully, but these errors were encountered: