Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ handling e2e testing with dockertest #43

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

ludusrusso
Copy link
Collaborator

@ludusrusso ludusrusso commented Apr 11, 2021

Add testing of database.

Some basic tests, but I prefer to have some :D

Related to #36

@davideimola
Copy link
Contributor

Probably for e2e I will suggest to use ginkgo, because executes the test concurrently.

@ludusrusso
Copy link
Collaborator Author

Probably for e2e I will suggest to use ginkgo, because executes the test concurrently.

Also with standart test libs we can handle tests in parallel :D

@ludusrusso ludusrusso marked this pull request as ready for review April 15, 2021 19:01
Copy link
Contributor

@davideimola davideimola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

Copy link
Contributor

@davideimola davideimola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideimola davideimola merged commit 7c06a7c into kannon-email:master Apr 15, 2021
@davideimola davideimola added the type/feature Feature label Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants