Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update robots.txt to hide older versions of the docs #3030

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

tynandebold
Copy link
Member

Description

Resolves #2980.

Development notes

We're being more explicit now about what we're allowing and disallowing.

Notably, changing Disallow: * to Disallow: / disallows crawling of the entire website. Under that rule, we then state what we want crawled, which @stichbury outlined here.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@tynandebold tynandebold self-assigned this Sep 13, 2023
@tynandebold tynandebold removed the request for review from yetudada September 13, 2023 10:53
Signed-off-by: Tynan DeBold <[email protected]>
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks.

Looking forward, we'll need to remember to add each release as it arises, so when it is no longer the 'stable' release, it is still indexed. I have added to the Release+step-by-step+checklist+Kedro on Confluence

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a quick test with https://technicalseo.com/tools/robots-txt/ and looks good!

@tynandebold tynandebold enabled auto-merge (squash) September 13, 2023 17:13
@tynandebold tynandebold merged commit 0fd1cac into main Sep 13, 2023
@tynandebold tynandebold deleted the chore/update-robots-txt branch September 13, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control excessive Kedro versions in search results
4 participants