Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs add Airflow KubernetesPodOperator #4529

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DimedS
Copy link
Member

@DimedS DimedS commented Feb 27, 2025

Description

Closes #4499 by providing guidance on executing a Kedro project in an isolated environment on Airflow Kubernetes using KubernetesPodOperator, along with the kedro-airflow and kedro-docker plugins.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @DimedS , this is great! Left a few comments, didn't test the code itself yet

```

### Running Multiple Nodes in a Single Container
By default, this approach runs each node in an isolated Docker container. However, to reduce computational overhead, you can choose to run multiple nodes together within the same container. If you opt for this, you must modify the DAG accordingly to adjust task dependencies and execution order.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this probably the preferred approach given the user feedback we got? If so, might be helpful to describe how exactly the user can achieve this, or what customisations are needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true! I tried to expand the description with an example - hope it's clearer now

Signed-off-by: Dmitry Sorokin <[email protected]>
@DimedS DimedS requested a review from astrojuanlu February 28, 2025 15:28
@DimedS
Copy link
Member Author

DimedS commented Feb 28, 2025

Thanks a lot @DimedS , this is great! Left a few comments, didn't test the code itself yet

Thanks for the review, @astrojuanlu! I tried to address all the comments and requested a re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Airflow page to include guidance on Kubernetes without kedro-airflow-k8s
2 participants