KTOR-6384 Fix Websocket Extension negotiation - #4709
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… protocols are delimited by comma and arguments by semicolon, not the other way around https://datatracker.ietf.org/doc/html/rfc6455#page-48
|
Hi @osipxd, no problem, that was an easy fix. Regarding the tests, is it possible that those are random failing? I have rerun those locally in Idea and they are green.. Do you have chance to rerun them? Thanks! |
|
Yes, those tests are flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 6455 protocols are delimited by comma and arguments by semicolon, not the other way around
https://datatracker.ietf.org/doc/html/rfc6455#page-48
Subsystem
Client/Server, Websocket extension
Motivation
Fixes a bug KTOR-6384
Solution
Just swap the delimeters for protocols and their arguments.