-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
central-dashboard: Configure build_version dynamically through ENV var #16
Comments
/transfer dashboard |
@orfeas-k: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/lifecycle frozen |
/kind feature
Context

At the moment, KF's
build version
in the dashboard is defined only during build time. More specifically and as explained thoroughly in this issue #25, it is not even defined and thus it is constantlydev_local
.For some more thorough technical context, in theory, it can also be defined during runtime through a
custom resource
that doesn't exist anymore in KF (here with the callback trace being 1, 2 and 3).Feature
Configure the build_version dynamically during runtime by using a deployment's ENV variable.
Why you need this feature:
This will allow for anyone to be able to configure the
build_version
value in their distribution without having to rebuild the image.Describe the solution you'd like:
The solution can be inspired at a great extent what has been done for
centraldashboard-angular
component in kubeflow/kubeflow#6918. The changes that really interest us are the ones in backend k8s_service.ts file. We could also consider splittingbuild_version
tobuildVersion
,buildId
andbuildLabel
but that's optional. Then, we may have to implement the new ENV variables here, although if we usekubeflowVersion
, changing only where k8s gets this variable from may be enough.The text was updated successfully, but these errors were encountered: