Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pull Request Template for UI team #299

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

lucferbux
Copy link
Contributor

Description

Following github's pull request template instructions, allow custom PR Template for UI contributions.

By default the common PR Template would appear, with a link to the UI one.

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@lucferbux
Copy link
Contributor Author

@ederign @tarilabs I've tested this in other repo to make sure it works, however I haven't been able to do that here.
I'm not even sure if this is a good flow, let me know your thoughts, I'm opening the PR to start a discussion.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

but how about "merging" the UI-related points into a section in the existing pull request template?

@tarilabs
Copy link
Member

btw @lucferbux can you kindly signoff your commit for DCO check, please?

https://wiki.linuxfoundation.org/dco

@tarilabs tarilabs assigned ederign and unassigned tarilabs Aug 26, 2024
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 26, 2024
@lucferbux
Copy link
Contributor Author

but how about "merging" the UI-related points into a section in the existing pull req

Yeah I'm sorry, I'm changing computers and I didn't have signoff enabled by default, thanks

@lucferbux
Copy link
Contributor Author

/lgtm

but how about "merging" the UI-related points into a section in the existing pull request template?

I don't mind that either, what do you think, @ederign ?

@Griffin-Sullivan
Copy link
Contributor

Yeah I would suggest since there's so much overlap with the normal template that we add a UI only section at the bottom for additional criteria.

@ederign
Copy link
Member

ederign commented Aug 26, 2024

Before reading this thread, I just suggested the same here -> #298 (comment)

+1 to have a single template.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lucferbux , see below minor suggestions

@ederign
Copy link
Member

ederign commented Aug 26, 2024

Thank you @lucferbux !

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks Lucas, will wait for another to go in then proceeding for merge.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit eb9a697 into kubeflow:main Aug 27, 2024
11 checks passed
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants