-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pull Request Template for UI team #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
but how about "merging" the UI-related points into a section in the existing pull request template?
btw @lucferbux can you kindly signoff your commit for DCO check, please? |
74024f4
to
9880905
Compare
Yeah I'm sorry, I'm changing computers and I didn't have signoff enabled by default, thanks |
I don't mind that either, what do you think, @ederign ? |
Yeah I would suggest since there's so much overlap with the normal template that we add a UI only section at the bottom for additional criteria. |
Before reading this thread, I just suggested the same here -> #298 (comment) +1 to have a single template. |
9880905
to
1c0f677
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lucferbux , see below minor suggestions
Signed-off-by: lucferbux <[email protected]>
1c0f677
to
fc3715b
Compare
Thank you @lucferbux ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks Lucas, will wait for another to go in then proceeding for merge.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: lucferbux <[email protected]>
Description
Following github's pull request template instructions, allow custom PR Template for UI contributions.
By default the common PR Template would appear, with a link to the UI one.
How Has This Been Tested?
Merge criteria: