Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the frontend mock folder #318

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

Griffin-Sullivan
Copy link
Contributor

Description

Just a quick PR to get the directory structure setup. We can delete the placeholder file there when we start adding mocks, but at the moment there's no other set up required.

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Griffin-Sullivan <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Aug 28, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 28, 2024
@google-oss-prow google-oss-prow bot merged commit e697fd8 into kubeflow:main Aug 28, 2024
14 checks passed
dhirajsb added a commit to dhirajsb/model-registry-kfp that referenced this pull request Aug 30, 2024
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants