Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isvc): made name and url optional - added support to svc url annotation #683

Conversation

Al-Pragliola
Copy link
Contributor

Description

This PR aims to add backwards compatibility to existing inferenceservices that are missing the new labels/annotations, so the following changes have been made:

  • made the name label and URL annotation optional, the reconciler will try to connect to a model registry service in the namespace specified by the label or the default (if missing), if there's more than one MR service it will stop and fail.
  • The reconciler will try to get the URL from the service's annotation if it's specified and it's present on the service, if it's missing it will build the URL using the name/namespace/rest-api port.

How Has This Been Tested?

make test

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@Al-Pragliola
Copy link
Contributor Author

Al-Pragliola commented Feb 6, 2025

/cc @pboyd kindly asking for your review 🙏🏼

Copy link
Contributor

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Al-Pragliola

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Al-Pragliola and @pboyd !

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pboyd, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member

tarilabs commented Feb 6, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 6, 2025
@google-oss-prow google-oss-prow bot merged commit 5c763d8 into kubeflow:main Feb 6, 2025
16 checks passed
@Al-Pragliola Al-Pragliola deleted the al-pragliola-inferenceservice-retrocompat branch February 6, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants