Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Windows 2004(EOL) with ltsc2019 #1231

Merged
merged 1 commit into from
May 9, 2022

Conversation

torredil
Copy link
Member

@torredil torredil commented May 9, 2022

Signed-off-by: Eddie Torres [email protected]

What is this PR about? / Why do we need it?

  • Stop building for Windows 2004 which has reached EOL for all editions.
  • Build ltsc2019.

What testing is done?

  • Deployed CSI driver with helm chart using new ltsc2019 image.

@torredil torredil requested review from rdpsin and gtxu May 9, 2022 15:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2022
@k8s-ci-robot k8s-ci-robot requested a review from bertinatto May 9, 2022 15:06
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@rdpsin
Copy link
Contributor

rdpsin commented May 9, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdpsin, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2022
@gtxu
Copy link
Contributor

gtxu commented May 9, 2022

The Dockerfile here needs update too.

@rdpsin
Copy link
Contributor

rdpsin commented May 9, 2022

Have we verified functionality with the new image? I don't expect there to be a problem, but don't want any surprises.

@torredil
Copy link
Member Author

torredil commented May 9, 2022

@gtxu Dockerfile has already been updated in this PR

@torredil
Copy link
Member Author

torredil commented May 9, 2022

@rdpsin Yeah deployed CSI driver with new ltsc2019 image and did some testing - all good.

@k8s-ci-robot k8s-ci-robot merged commit 864a106 into kubernetes-sigs:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants