-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enableMetrics configuration #1380
Conversation
Signed-off-by: Eddie Torres <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current version lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3, rdpsin, torredil, wmesard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
namespace: kube-system | ||
labels: | ||
app: ebs-csi-controller | ||
release: prometheus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if these labels were configurable / overridable without needing to use helm's kustomize post-renderers support.
In my setup release
label should have a different value. Maybe app
label can remain fixed, but release: prometheus
one should ideally be part of e.g. controller.serviceMonitor.additionalLabels
, to allow for overrides. Then also enable switch can be moved under controller.serviceMonitor.enabled
WDYT @torredil ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this PR about? / Why do we need it?
This PR adds a Helm chart configuration which facilitates scraping AWS metrics when
enableMetrics
is set to true and the Prometheus Operator is installed, by deploying:A Service object that exposes the EBS CSI Driver's controller metric port through a
ClusterIP
.A ServiceMonitor object which updates the Prometheus scrape configuration and allows scraping metrics from the endpoint defined. For more information, see the manifest
metrics.yaml
.httpEndpoint
is deprecated.What testing is done?
docs/metrics.md
.Signed-off-by: Eddie Torres [email protected]