Add resolver to handle custom endpoints #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, setting the AWS_EC2_ENDPOINT environment variable overwrites the STS endpoint as well. This patch adds a custom resolver to only set a custom endpoint on EC2 service.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
lgtm but lets wait for @wongma7 input as well. /lgtm |
k8s-ci-robot
added
do-not-merge/hold
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setting the AWS_EC2_ENDPOINT environment variable overwrites the STS endpoint as well. This patch adds a custom resolver to only set a custom endpoint in EC2 service.
Is this a bug fix or adding new feature?
This should fix #1122.
What is this PR about? / Why do we need it?
What testing is done?
Manual tested in a cluster with custom endpoints and STS.