Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target to run External Storage tests on Windows nodes #1521

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Add target to run External Storage tests on Windows nodes #1521

merged 1 commit into from
Apr 17, 2023

Conversation

torredil
Copy link
Member

@torredil torredil commented Mar 3, 2023 •
edited
Loading

What is this PR about? / Why do we need it?

  • Add test-e2e-external-eks-windows target to run the External Storage tests on Windows nodes.
  • Known issues:
    1. GINKGO_PARALLEL=1. Running the tests in parallel will sometimes trigger a bug when mounting volumes:

Fixed by #1526.

2. Skipped test volumeLimits [It] should verify that all csinodes have volume limits - Known bug; CSINode Allocatable property is not set on Windows nodes:

Fixed by #1561.

$ kubectl describe csinode                                             
Name:               ip-192-168-59-155.us-west-2.compute.internal
Labels:             <none>
Annotations:        storage.alpha.kubernetes.io/migrated-plugins:
                      kubernetes.io/aws-ebs,kubernetes.io/azure-disk,kubernetes.io/azure-file,kubernetes.io/cinder,kubernetes.io/gce-pd
CreationTimestamp:  Thu, 26 Jan 2023 02:27:42 +0000
Spec:
  Drivers:
    ebs.csi.aws.com:
      Node ID:        i-010d661aaeceaa025
      Topology Keys:  [topology.ebs.csi.aws.com/zone]
Events:               <none>

What testing is done?

$ docker run -it --privileged --rm --entrypoint /bin/bash gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230207-192d5afee3-master
$ git clone https://github.com/torredil/aws-ebs-csi-driver.git && cd aws-ebs-csi-driver && git checkout e2e-windows
$ export GOPROXY=direct && dockerd &
$ CLUSTER_TYPE=eksctl K8S_VERSION=1.24 HELM_VALUES_FILE=./hack/values_eksctl.yaml make test-e2e-external-eks-windows &

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from ConnorJC3 and gtxu March 3, 2023 16:23
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2023
@torredil
Copy link
Member Author

torredil commented Mar 3, 2023

/hold do not merge until 1.27

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2023
@torredil
Copy link
Member Author

torredil commented Mar 3, 2023

logs.txt

@torredil torredil mentioned this pull request Mar 9, 2023
Merged
hanyuel
hanyuel reviewed Mar 21, 2023
View reviewed changes
hanyuel
hanyuel reviewed Mar 21, 2023
View reviewed changes
ConnorJC3
ConnorJC3 reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very rough initial review, will give a more thorough review once all the prerequisites are in place

@ConnorJC3
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023
ConnorJC3
ConnorJC3 reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor problems, otherwise tentatively lgtm - I will be running it locally before I give a full lgtm though

@torredil
Copy link
Member Author

/retest

2 similar comments
@torredil
Copy link
Member Author

/retest

@torredil
Copy link
Member Author

/retest

@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@torredil
Copy link
Member Author

/retest

4 similar comments
@torredil
Copy link
Member Author

/retest

@ConnorJC3
Copy link
Contributor

/retest

@ConnorJC3
Copy link
Contributor

/retest

@torredil
Copy link
Member Author

/retest

@ConnorJC3
Copy link
Contributor

/remove-hold
/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@torredil
Copy link
Member Author

/retest

3 similar comments
@torredil
Copy link
Member Author

/retest

@ConnorJC3
Copy link
Contributor

/retest

@torredil
Copy link
Member Author

/retest

@ConnorJC3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, hanyuel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 47645fa into kubernetes-sigs:master Apr 17, 2023
@torredil torredil mentioned this pull request Apr 18, 2023
Merged
This was referenced Jul 31, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 left review comments

@hanyuel hanyuel hanyuel approved these changes

@gtxu gtxu Awaiting requested review from gtxu

Assignees

@ConnorJC3 ConnorJC3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@torredil @ConnorJC3 @k8s-ci-robot @hanyuel